fix: prior and posterior profile plotting #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Named columns with prior explicitly: prior_bias and prior_sq Prior and prior+posterior plotting of rmse, bias, total spread Note the prior plotting does not need the dataframe reshaping to long, but leaving it in to be consistant with plot_profile_prior_post for now.
|
reverse axis for pressure a62ce63 |
Now prior columns are named 'prior_bias', 'prior_sq_err'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage ? 68.81%
=======================================
Files ? 2
Lines ? 574
Branches ? 0
=======================================
Hits ? 395
Misses ? 179
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior and Prior+posterior profile plotting. #9
Named columns with prior explicitly: prior_bias and prior_sq
Prior and prior+posterior plotting of rmse, bias, total spread
Note the prior plotting does not need the dataframe reshaping to long, but leaving it in to be consistent with plot_profile_prior_post for now.
I'm not sure whether plotly is the way forwards, it is pretty and nice to have the interactive plots (click by type), but matplotlib might be a better option going forwards to reproduce the DART Matlab plots. Or not. Sticking with plotty for now.
example of clickable type plot: (note y axis needs reversing)