Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when file is truncated and cannot be read #569

Closed
jordanpadams opened this issue Dec 2, 2022 · 2 comments · Fixed by #570
Closed

Improve error message when file is truncated and cannot be read #569

jordanpadams opened this issue Dec 2, 2022 · 2 comments · Fixed by #570
Assignees

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Dec 2, 2022

📖 Additional Details

As a follow on to #568, we need to more clearly provide input to a user when a data object is shorter than the remaining file available.

Current error message:

  FAIL: file:/Users/jpadams/Downloads/insufficient.content.validation/uvis_euv_2016_288_solar_time_series_egress.xml
      ERROR  [error.label.table_definition_problem]   line 2: Data Object #2: Cannot read object. Remaining file size: 342160, Expected bytes remaining for object: 343720
        2 product validation(s) completed

Maybe not how many rows are expected to be read and not that the file is truncated and only X number of records can be read (this can be done using a simple calculation versus actually trying to read the data).

@jordanpadams jordanpadams self-assigned this Dec 2, 2022
@jordanpadams
Copy link
Member Author

jordanpadams commented Dec 2, 2022

@mit3ch how is this error message?

FAIL: file:/Users/jpadams/Downloads/insufficient.content.validation/uvis_euv_2016_288_solar_time_series_egress.xml
      ERROR  [error.label.table_definition_problem]   line 2: Data Object #2 (Identifier Not Specified): Data object is truncated. Expected bytes as defined by label: 343720 (1322 records), Actual bytes remaining in file: 342160 (1316 records)
        1 product validation(s) completed

@mit3ch
Copy link

mit3ch commented Dec 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants