Fixes/121 search textfield update #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added fix to update search box when navigating from back or forward in history. -Added fix for invalid investigation lids causing crash. Example search for "arecibo"
-Added fix to keep the value of the search text when returning from the back button and then selecting a new checkbox.
-Fixed the message that shows on the search page when unrelated filters are selected from the home page.
-Fixed the label showing as "0 selected" instead of "all" when the filter chip X button is clicked. -The "all" checkbox is now shown as checked when all chips are deselected.
-The all value is removed from single select filters since it should not be able to be selected. It is already acting as if all is selected when nothing is selected.
|
|
Sonarcloud code analysis says to use if/else statements but in the referenced article explicitly says Sonar rule for nested ternaries does not apply to JSX. The reason being JSX doesn't allow for if/else statements. Will leave as is since it is clear from JSX what is going on. It picked up the code as Javascript instead of JSX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This PR fixes the following issues:
⚙️ Test Data and/or Report
Build has been tested. Run this branch with wds-react develop branch. Test for the above bugs by attempting to replicate issue.
♻️ Related Issues