Using back/forward buttons on search results page does not update the text in the search textfield

[anilnatha]

💡 Description

There is an issue on the search page when using the back/forward browser buttons.

How to reproduce issue:

If you start a search on the homepage using the search header for say "mars":

Then when you hit enter you arrive on the search results page:

Do another search with the term "jupiter" in the text field in the body of the page:

Then you see the "jupiter" results:

Then click the back button, you'll see the textfield on the search page doesn't update, but the results show the "mars" results:

⚔️ Parent Epic / Related Tickets

No response

[eddiesarevalo]

This issue is caused by the search bar in the search screen being uncontrolled. Its uncontrolled because the amount of checkboxes slows the page down considerably. The filters can't be redrawn on textbox state change without causing this. Therefore will attempt to change to controlled with the import { useDebouncedCallback } from "use-debounce" solution that is used in the instruments page.

While testing for this more bugs were found on the home page:

• Selecting multiple dropdowns in homepage doesn’t show on search correctly. The results not found message to allow removal doesn’t render right and the filters don't show checked.
• Clicking x on a selected dropdown in search will show “0 selected” instead of all on the home page.
• all still shows in page_type search page.

[eddiesarevalo]

Adding one more bug.

Certain search text for example "arecibo" will just cause a crash:

[eddiesarevalo]

Debouncer solution did not work. The underlying issues are different.In the investigations page its a lag when displaying the results. In the search page its a lag when updating the state value of the search box. Used an alternative solution that sets the uncontrolled value of the input box using basic javascript and ids.

[eddiesarevalo]

Another bug:
On the home page, if returning from back,then selecting a checkbox and searching again will clear out the text from the url causing a new search to omit the search text.

[eddiesarevalo]

Fix Navigation Not Updating Search Box In Search Page and Certain search text for example "arecibo" will just cause a crash: fixed in 5c1a535

Fix Search Text Being Omitted After Back Navigation fixed in 87bfe84

Fix Unrelated Filters Message fixed in 8ae1e62

Fix 0 Selected Message On Homepage When Chips Exited fixed in 5010f1f

Omit The All Value From Single Select Filters fixed in a670940