Submit STAC using transactions API #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ividito
force-pushed
the
feat/transactions-api
branch
from
ad3fac7 to
cccda9e
Compare
| class TransactionsApi: | ||
|
|
||
| @classmethod | ||
| def from_veda_auth_secret(cls, *, secret_id: str, base_url: str) -> "IngestionApi": |
There was a problem hiding this comment.
Shouldn't the return type hint be "TransactionsApi" instead of "IngestionApi"
| response.raise_for_status() | ||
| except Exception as ex: | ||
| print(response.text) | ||
| raise f"Error, {ex}" |
There was a problem hiding this comment.
Raise should be derived from a baseException otherwise it won't raise a string 🤔
Probably we should use
raise RuntimeError(f"Error, {ex}")| :param token: Optional Bearer token for authenticated STAC APIs. | ||
| """ | ||
| self.stac_ingestor_api_url = stac_ingestor_api_url.rstrip('/') | ||
| self.cognito_app_secret = cognito_app_secret |
There was a problem hiding this comment.
Where are we using self.cognito_app_secret?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed implementation for #288
Original ingest API support is maintained through an Airflow variable. I learned while setting this up that this is not a recommended approach, but it is consistent with what we do elsewhere.