Optimize language options #56

NtskwK · 2024-09-05T03:13:05Z

No description provided.

feat: 增加自动化编译测试

N0I0C0K · 2024-09-05T14:31:14Z

Hi! 首先很高兴看到你的 PR，提出了一些问题，期待讨论

N0I0C0K · 2024-09-05T14:33:38Z

同时前面几个如果有重复的话可以关闭掉了

NtskwK · 2024-09-05T14:37:01Z

优化语言选项，安装脚本修复，自动化编译测试脚本。这三个是不同的分开提交方向（是的，他们没有重复）有利于单独进行调整。

需要进行单独讨论的问题不会影响其他功能的提交。🤣

N0I0C0K · 2024-09-06T13:06:59Z

同时回复一下 cr 中的 comment 吧

NtskwK · 2024-09-06T13:19:55Z

#36

N0I0C0K · 2024-09-05T14:23:58Z

lib/.gitignore

@@ -0,0 +1 @@
+./*


没有必要再传 lib 文件夹，我理解有需要的话会运行 lib.bat 来生成

N0I0C0K · 2024-09-05T14:24:36Z

packages.lock.json

+{
+  "version": 1,
+  "dependencies": {
+    "net8.0-windows7.0": {}
+  }


没有必要用包管理

是的，不需要。这只是为了通过现有的编译actions。
https://github.com/N0I0C0K/PowerTranslator/actions/runs/9919108964
如果你确实不需要包管理，可以在actions中删除对应的步骤。我会马上跟进。

原来是这样，之前加 Action 目的是为了尝试一下 GitHub 能否提供 arm 平台，那倒是应该保留

不必要的包管理器可以被移除了#58

应该可以在一个 pr 里去提交这些更改？

我更喜欢将不同的功能拆分。当一个pr的commit很多时，如果其中一个feat出了问题，可能导致其他的feat也被堵住。

我指的就是拆开，但是这里明显不是优化 language 相关的，分离出去

事实上，还有一个问题是。编译脚本的分支只能从release的commit点fork出来，否则现在的代码库无法通过编译。但是其他的没有问题，可以直接从HEAD节点fork。

N0I0C0K · 2024-09-05T14:25:48Z

src/SettingHelper.cs

+        public abstract class Languages
        {
-            var lanuageItems = languagesOptions.Select((val, idx) =>
+            private static readonly Dictionary<string, string> LanguageContrast = new Dictionary<string, string>
            {
-                return new KeyValuePair<string, string>(val, idx.ToString());
-            }).ToList();
-            var dictItems = dictUrlPatternKeys.Select((val, idx) =>
+                { "auto", "auto" },
+                { "zh-CHS", "Chinese (Simplified)" },
+                { "zh-CHT", "Chinese (Traditional)" },
+                { "en", "English" },
+                { "ja", "Japanese" },
+                { "ko", "Korean" },
+                { "ru", "Russian" },
+                { "fr", "French" },
+                { "es", "Spanish" },
+                { "ar", "Arabic" },
+                { "de", "German" },
+                { "it", "Italian" },
+                { "he", "Hebrew" },
+            };
+
+            private static readonly Dictionary<string, string> LanguageAbbreviation = new Dictionary<string, string>
+            {
+                { "zhs", "zh-CHS" },
+                { "zht", "zh-CHT" },
+            };
+
+            public static string MatchLanguageCode(string languageKey)
+            {
+                string defaultLanguageCode = "auto";
+                languageKey = languageKey is null ? defaultLanguageCode : languageKey;
+                LanguageAbbreviation.TryGetValue(languageKey, out languageKey);
+                LanguageContrast.TryGetValue(languageKey, out defaultLanguageCode);
+                return defaultLanguageCode;
+            }
+
+            public static List<KeyValuePair<string, string>> ContrastList()
+            {
+                return LanguageContrast.ToList();
+            }
+        }


我倾向于单独出来，不要放到 SettingHelper下

赞成，把配置里允许的选项和Setting本身单独封装是一个不错的想法。

N0I0C0K · 2024-09-05T14:26:51Z

src/TranslateHelper.cs

@@ -24,7 +31,7 @@ public struct TranslateTarget
    private object initLock = new Object();
    private long lastInitTime = 0;
    private IPublicAPI publicAPI;
-    private List<Youdao.ITranslator?> translators;
+    private List<Translator.Youdao.ITranslator?> translators;


多余的？同下

N0I0C0K · 2024-09-05T14:28:52Z

src/TranslateHelper.cs

@@ -35,7 +42,7 @@ public TranslateHelper(IPublicAPI publicAPI, string defaultLanguageKey = "auto")
            null, null, null
        };
        translatorTypes = new List<Type>{
-            typeof(Youdao.V2.YoudaoTranslator),
+            typeof(Translator),


不能这样做，是需要实现了 ITranslator 的类型

N0I0C0K · 2024-09-05T14:29:21Z

src/Youdao/YoudaoTranslatorV2.cs

@@ -8,7 +8,7 @@
 using Translator.Utils;
 using Wox.Plugin.Logger;

-namespace Translator.Youdao.V2;
+namespace Translator.Youdao;


需要单独开，他是 youdao 下单独的版本

N0I0C0K · 2024-09-05T14:30:02Z

src/SettingHelper.cs

+        public static readonly List<string> DictUrlPatternKeys = new List<string> { "Youdao", "Oxford", "Cambridge" };
+        public static readonly List<string> DictUrlPatternValues = new List<string> { "https://www.youdao.com/result?word={0}&lang=en", "https://www.oed.com/search/dictionary/?scope=Entries&q={0}", "https://dictionary.cambridge.org/us/dictionary/english/{0}" };
+        public static readonly List<PluginAdditionalOption> PluginAdditionalOptions = GetAdditionalOptions();
+        public string DefaultLanguageKey = "auto";
+        public bool EnableSuggest = true;
+        public bool EnableAutoRead = false;
+        public bool EnableSecondLanuage = false;
+        public string SecondLanuageKey = "auto";
+        public bool ShowOriginalQuery = false;
+        public bool EnableJumpToDict = false;
+        public string DictUtlPattern = DictUrlPatternValues[0];


更倾向于 lower camel case

抱歉，编辑器设置成了自动调整规范。C# 标识符命名规则和约定

如果你坚持，我会与你同步。

其他的规范我倒是没问题，主要是字段也是 PascalCase，首字母大写不是很舒服

也可以改吧，我使用的是 vscode 作为编辑器，没有太多的 C# 内置支持，所以一直按照的是自己的规范

N0I0C0K · 2024-09-06T13:35:51Z

#36

忘记提交 review 了，我的问题

N0I0C0K · 2024-09-06T13:56:48Z

还有一个想法想提一下，之前一直想把常量数据转移到 Resources 下，方便管理，也为了后面接入 i18n，但奈何一直没有时间

NtskwK · 2024-09-06T17:17:44Z

抱歉，我不是很懂C#项目的标准目录结构，请问有关语言选项的重构是直接独立成新的文件和其他选项放在另一个文件夹里吗。

如果你已经在做，那真是太好了。🥳🥳

此PR的内容已经结束。如果没有其他问题，你可以关闭它。我们可以在其他的议题中讨论。

NtskwK · 2024-09-07T07:19:16Z

我指的就是拆开，但是这里明显不是优化 language 相关的，分离出去

@N0I0C0K 好的，我会先关闭#56，因为这个拉取太乱了。如果还有需要处理的内容，请告诉我，我会重新开始一个分支。

N0I0C0K · 2024-09-10T12:43:11Z

好的，很高兴你的贡献

NtskwK added 6 commits September 5, 2024 02:43

feat: 增加自动化编译测试

c9408a8

Merge pull request #1 from NtskwK/new_action

acaa044

feat: 增加自动化编译测试

feat: 重构语言选择模块

68ad912

feat: update .gitignore

f8fd2ef

feat: update files

4068bba

feat: 重命名以减少报警

18abe4c

N0I0C0K reviewed Sep 6, 2024

View reviewed changes

NtskwK closed this Sep 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize language options #56

Optimize language options #56

NtskwK commented Sep 5, 2024

N0I0C0K commented Sep 5, 2024

N0I0C0K commented Sep 5, 2024

NtskwK commented Sep 5, 2024 •

edited

Loading

N0I0C0K commented Sep 6, 2024

NtskwK commented Sep 6, 2024

N0I0C0K Sep 5, 2024

N0I0C0K Sep 5, 2024

NtskwK Sep 6, 2024 •

edited

Loading

N0I0C0K Sep 6, 2024

NtskwK Sep 6, 2024

N0I0C0K Sep 7, 2024

NtskwK Sep 7, 2024

N0I0C0K Sep 7, 2024

NtskwK Sep 7, 2024

N0I0C0K Sep 5, 2024

NtskwK Sep 6, 2024

N0I0C0K Sep 5, 2024

N0I0C0K Sep 5, 2024

N0I0C0K Sep 5, 2024

N0I0C0K Sep 5, 2024

NtskwK Sep 6, 2024 •

edited

Loading

N0I0C0K Sep 6, 2024

N0I0C0K Sep 6, 2024

N0I0C0K commented Sep 6, 2024

N0I0C0K commented Sep 6, 2024

NtskwK commented Sep 6, 2024

NtskwK commented Sep 7, 2024

N0I0C0K commented Sep 10, 2024

		@@ -0,0 +1 @@
		./*

Optimize language options #56

Optimize language options #56

Conversation

NtskwK commented Sep 5, 2024

N0I0C0K commented Sep 5, 2024

N0I0C0K commented Sep 5, 2024

NtskwK commented Sep 5, 2024 • edited Loading

N0I0C0K commented Sep 6, 2024

NtskwK commented Sep 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NtskwK Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NtskwK Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

N0I0C0K commented Sep 6, 2024

N0I0C0K commented Sep 6, 2024

NtskwK commented Sep 6, 2024

NtskwK commented Sep 7, 2024

N0I0C0K commented Sep 10, 2024

NtskwK commented Sep 5, 2024 •

edited

Loading

NtskwK Sep 6, 2024 •

edited

Loading

NtskwK Sep 6, 2024 •

edited

Loading