Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update hyper et al #18805

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore: update hyper et al #18805

merged 1 commit into from
Jul 26, 2024

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Jul 25, 2024

Update a number of http related libraries, including but not limited to:

  • hyper
  • axum
  • rustls

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Jul 25, 2024

@bmwill is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 1:11pm

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you can fix the failing tests, but overall this looks great. Thanks a lot!

I'd love if other folks have a look over it!

Update a number of http related libraries, including but not limited to:
- hyper
- rustls
- axum
@bmwill bmwill merged commit 07446ba into MystenLabs:main Jul 26, 2024
41 of 45 checks passed
@bmwill bmwill deleted the update-http branch July 26, 2024 13:59
None
let stream = response
.into_inner()
.take_while(|b| futures::future::ready(b.is_ok()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this line useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its to temporarily work around a small bug i found in tonic that i've fixed upstream but there isn't a release out for it yet: hyperium/tonic#1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants