[bridge] add BridgeMonitor and handle url change event #18790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
patrickkuo
approved these changes
Jul 26, 2024
crates/sui-bridge/src/monitor.rs
Outdated
Comment on lines
108
to
117
| let member = committee.member(&BridgeAuthorityPublicKeyBytes::from(&event.member)); | ||
| if member.is_none() { | ||
| // This is possible when a node is processing an older event while the member quitted at a later point, which is fine. | ||
| // Or fullnode returns a stale committee that the member hasn't joined, which is rare and tricy to handle so we just log it. | ||
| warn!( | ||
| "Committee member not found in the committee: {:?}", | ||
| event.member | ||
| ); | ||
| return committee; | ||
| } |
There was a problem hiding this comment.
can do let Some(member) = .... else instead?
longbowlu
force-pushed
the
bridge-monitor
branch
from
84eebae to
cba2ef2
Compare
longbowlu
force-pushed
the
bridge-monitor
branch
from
cba2ef2 to
5450f3e
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description This PR adds `BridgeMonitor` which receives all `SuiBridgeEvent` (and probably `EthBridgeEvent` as well soon) and handles them accordingly. In this PR we add the handling for `CommitteeMemberUrlUpdateEvent` by retrieving the latest committee onchain and swap it in. ## Test plan added unit tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
BridgeMonitorwhich receives allSuiBridgeEvent(and probablyEthBridgeEventas well soon) and handles them accordingly. In this PR we add the handling forCommitteeMemberUrlUpdateEventby retrieving the latest committee onchain and swap it in.Test plan
added unit tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.