Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User credit result/#91 #93

Merged
merged 8 commits into from
May 6, 2024
Merged

User credit result/#91 #93

merged 8 commits into from
May 6, 2024

Conversation

gahyuun
Copy link
Member

@gahyuun gahyuun commented May 2, 2024

๐Ÿ“Œ ์ž‘์—… ๋‚ด์šฉ

close #91

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • user credit result ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„
  • drawer bar ์ถ”๊ฐ€
  • user info query api์— ๋งž๊ฒŒ ์ˆ˜์ •
  • empty data container ์‚ญ์ œ

๐Ÿค” ๊ณ ๋ฏผ ํ–ˆ๋˜ ๋ถ€๋ถ„

  • empty data container์„ ์•„๋ž˜์˜ ์ด์œ ๋กœ ์‚ญ์ œํ•˜๊ณ  LectureSearch ์ปดํฌ๋„ŒํŠธ์— ํ•ฉ์ณค๋Š”๋ฐ ํŒ€์›๋ถ„๋“ค ์ƒ๊ฐ์€ ์–ด๋– ์‹ ๊ฐ€์š”!?
  • ์ด๊ฑฐ์— ๋Œ€ํ•œ ๋…ผ์˜๋ฅผ ๊นŒ๋จน๊ณ  ๋จธ์ง€๋ฅผ ํ•ด๋ฒ„๋ ค์„œ ์ด๋ฒˆ pr์— ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค ใ… ใ… 
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-05-02 แ„‹แ…ฉแ„’แ…ฎ 1 39 01

@gahyuun gahyuun self-assigned this May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Copy link
Member

@yougyung yougyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty data container์„ ์•„๋ž˜์˜ ์ด์œ ๋กœ ์‚ญ์ œํ•˜๊ณ  LectureSearch ์ปดํฌ๋„ŒํŠธ์— ํ•ฉ์ณค๋Š”๋ฐ ํŒ€์›๋ถ„๋“ค ์ƒ๊ฐ์€ ์–ด๋– ์‹ ๊ฐ€์š”!?

์šฐ๋ ค๋˜๋Š” ๋ฌธ์ œ๋Š” ์˜ˆ์ƒ๋˜์ง€์•Š๋„ค์š”. ์ข‹์•„๋ณด์ž…๋‹ˆ๋‹ค.

@@ -13,7 +13,7 @@ export default async function UserInfoNavigator() {
<span className="font-semibold">{userInfo.studentName}</span>
<span>๋‹˜</span>
</div>
<div className="mb-3 text-sm">{userInfo.major}</div>
<div className="mb-3 text-sm">{userInfo.completionDivision[0].major}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฃผ์ „๊ณต ํ•˜๋‚˜๋งŒ ๋…ธ์ถœํ•˜์‹ค ๊ณ„ํš์ด์‹ ๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์ด๊ฑฐ๋Š” mock ๋ฐ์ดํ„ฐ๋ฅผ ๋ฐ”๊พธ๋ฉด์„œ ์˜ค๋ฅ˜๊ฐ€ ๋‚˜์ง€ ์•Š๊ฒŒ๋” ๋ฐ”๊พผ ๊ฒƒ์ด๊ณ  ์–ด๋–ค ๊ฑฐ ๋…ธ์ถœํ•  ์ง€๋Š” user info navigator ๋‹ด๋‹นํ•˜์‹  ๋ถ„์ด ์ˆ˜์ •ํ•˜์ง€ ์•Š์„๊นŒ์‹ถ์Šต๋‹ˆ๋‹ค..!

Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค

Comment on lines +12 to +22
const emptyDataRender = () => {
return (
<div className="flex flex-col items-center justify-center gap-4">
<Image src={searchResultIcon} alt="search-result-icon" width={40} height={40} />
<div className="text-md font-medium text-gray-400 text-center whitespace-pre-wrap">
๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ๊ฐ€ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค
<br />ํ•œ ๊ธ€์ž ์ด์ƒ ๊ฒ€์ƒ‰ํ•ด์ฃผ์„ธ์š”
</div>
</div>
);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ์ ์ ˆํ•ด ๋ณด์ด๋„ค์š”

@gahyuun gahyuun merged commit 2353533 into main May 6, 2024
3 checks passed
@gahyuun gahyuun deleted the total-credit-result/#91 branch May 6, 2024 01:30
@yougyung yougyung restored the total-credit-result/#91 branch May 6, 2024 04:01
@yougyung yougyung deleted the total-credit-result/#91 branch August 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants