storybook 및 chromatic 설정 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yougyung
previously approved these changes
Feb 15, 2024
seonghunYang
previously approved these changes
Feb 15, 2024
package.json
Outdated
| "lint-staged": "lint-staged", | ||
| "storybook": "storybook dev -p 6006", | ||
| "build-storybook": "storybook build", | ||
| "chromatic": "npx chromatic --project-token=chpt_74ff4fb76a7b30e" |
There was a problem hiding this comment.
[comment]
이 project-token은 암호화할 필요가 없는 토큰인가요?
There was a problem hiding this comment.
storybook에서 script를 자동으로 설정해주어서 project-token이 노출되고 있는지 몰랐습니다ㅠ
금전적인 문제가 있진 않겠지만 project-token을 가지고 저희 프로젝트 chromatic에 아무나 story를 올릴 수 있는 문제가 있어서 project-token을 재발급 받았고 해당 script는 삭제했습니다!
참고로 pr 시 자동으로 빌드가 되기에 불필요하다고 생각해 삭제했습니다
yougyung
previously approved these changes
Feb 15, 2024
seonghunYang
previously approved these changes
Feb 15, 2024
|
저 궁금한 점이 생겼는데, RSC에 대한 스토리북 지원 여부나 이슈에 대해 혹시 설정하시면서 알게 된게 있으신가요? |
설정하면서 알게 된 건 아닌데 최근에 아티클을 통해 비동기나 모듈 모킹에 대해 storybook이 실험적인 기능을 제공한다는 걸 알게 되었어요! |
yougyung
approved these changes
Feb 15, 2024
seonghunYang
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용
storybook sample code를 작성했고 github actions 를 통해 pr을 올릴때마다 comment로 storybook 배포 링크를 첨부하도록 설정했습니다