Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBO-338 Improved indexing of corresponding author #406

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Possommi
Copy link
Collaborator

@Possommi Possommi commented Jul 17, 2024

Copy link
Member

@fluetze fluetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole template needs refactoring.

It all starts with
<xsl:apply-templates select="descendant::mods:name[@type='personal']/mods:role/mods:roleTerm[@type='code']" mode="solrField" />

The "descendant::" will cause those fields to be built also for included relatedItems that are NOT type host. Do we really want that?
And the ../../mods:role/mods:roleTerm will go "up", whatever that "up" is - may be even not a host-child relation.

@Possommi
Copy link
Collaborator Author

The whole template needs refactoring.

It all starts with <xsl:apply-templates select="descendant::mods:name[@type='personal']/mods:role/mods:roleTerm[@type='code']" mode="solrField" />

The "descendant::" will cause those fields to be built also for included relatedItems that are NOT type host. Do we really want that? And the ../../mods:role/mods:roleTerm will go "up", whatever that "up" is - may be even not a host-child relation.

What mods:roleTerms should be considered, what was the reason for using the descendant::mods:nameaxis in the first place?

@Possommi
Copy link
Collaborator Author

Possommi commented Aug 5, 2024

@kponten Could you please advice.

@fluetze
Copy link
Member

fluetze commented Aug 12, 2024

The whole template needs refactoring.
It all starts with <xsl:apply-templates select="descendant::mods:name[@type='personal']/mods:role/mods:roleTerm[@type='code']" mode="solrField" />
The "descendant::" will cause those fields to be built also for included relatedItems that are NOT type host. Do we really want that? And the ../../mods:role/mods:roleTerm will go "up", whatever that "up" is - may be even not a host-child relation.

What mods:roleTerms should be considered, what was the reason for using the descendant::mods:nameaxis in the first place?

The reason was to index mods:name's located in relatedItem[@type='host|series'] too, I think. But that was before we introduced other relation types. So we need to define and agree upon what metadata from related items should be found/indexed for a publication.

@kkrebs
Copy link
Contributor

kkrebs commented Aug 13, 2024

perhaps we should solve this with a separate template and not include in an existing one? Like:
<xsl:apply-templates select="mods:name[@type='personal']/mods:role/mods:roleTerm[text()='corresponding_author']" ...

@kponten
Copy link
Collaborator

kponten commented Aug 13, 2024

In my opinion, only the role in the genre should be relevant for the search for the CA. CAs from a relatedItem should not be indexed.

@kkrebs kkrebs merged commit 45ae3a3 into develop Aug 14, 2024
1 check passed
@kkrebs kkrebs deleted the issues/UBO-338-Search-for-CA-returns-false-results branch August 14, 2024 10:04
kkrebs added a commit that referenced this pull request Aug 23, 2024
* develop:
  UBO-355 Add more batch editor configuration
  UBO-356 enable classification mapping for destatis classification
  UBO-353 FSU040THUL-4126 Do not copy connection id of the replaced author (#414)
  UBO-354 Omit credentials (to bypass http basic auth) when fetching language classification
  UBO-352 FSU040THUL-1064 Made whole badge indicating duplicates clickable, support English in badge (#413)
  UBO-338 Improved indexing of corresponding author (#406)
  UBO-351 Improved logging in UBOUserByConnectionResolver (#412)
  UBO-350 Set pica2mods version to 2.10 (#411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants