-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBO-338 Improved indexing of corresponding author #406
UBO-338 Improved indexing of corresponding author #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole template needs refactoring.
It all starts with
<xsl:apply-templates select="descendant::mods:name[@type='personal']/mods:role/mods:roleTerm[@type='code']" mode="solrField" />
The "descendant::" will cause those fields to be built also for included relatedItems that are NOT type host. Do we really want that?
And the ../../mods:role/mods:roleTerm will go "up", whatever that "up" is - may be even not a host-child relation.
What |
@kponten Could you please advice. |
The reason was to index mods:name's located in relatedItem[@type='host|series'] too, I think. But that was before we introduced other relation types. So we need to define and agree upon what metadata from related items should be found/indexed for a publication. |
perhaps we should solve this with a separate template and not include in an existing one? Like: |
In my opinion, only the role in the genre should be relevant for the search for the CA. CAs from a relatedItem should not be indexed. |
* develop: UBO-355 Add more batch editor configuration UBO-356 enable classification mapping for destatis classification UBO-353 FSU040THUL-4126 Do not copy connection id of the replaced author (#414) UBO-354 Omit credentials (to bypass http basic auth) when fetching language classification UBO-352 FSU040THUL-1064 Made whole badge indicating duplicates clickable, support English in badge (#413) UBO-338 Improved indexing of corresponding author (#406) UBO-351 Improved logging in UBOUserByConnectionResolver (#412) UBO-350 Set pica2mods version to 2.10 (#411)
UBO-338