MCR 3173 fix pmd issues in mycore mods #2237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antoniafriedrich
requested review from
sebhofmann,
golsch and
rsteph-de
and removed request for
sebhofmann and
golsch
rsteph-de
reviewed
Sep 3, 2024
| @@ -110,11 +117,14 @@ public static MCRObject wrapMODSDocument(Element modsDefinition, String projectI | |||
| * @return true, if mods is supported | |||
| */ | |||
| public static boolean isSupported(MCRObject obj) { | |||
| boolean supported; | |||
There was a problem hiding this comment.
What's the advantage of this additional variable?
We could even further simplify and remove the if by an OR operator
return isSupported(obj.getId()) || ...
rsteph-de
reviewed
Sep 3, 2024
mycore-mods/src/main/java/org/mycore/mods/csl/MCRModsItemDataProvider.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.