Admin destroy User UI #2725

JoeCohen · 2025-02-18T23:12:25Z

Changes the Destroy User link (in the User show page while in admin mode) to a button.
Delivers Destroy User UI #2722

Turn on Admin Mode
click List Users (in the left side menu)
click the login of a verified user
click Destroy User
Expected Result:
- re-displays user index (Users by Name)
- a flash like "Sorry, the user you tried to display (id #189894) does not exist. ..."
- that user is toast.

- Tests that the button goes to the right place.

Matches (rather than equals) admin_user_path

coveralls · 2025-02-18T23:31:24Z

coverage: 93.502% (+0.02%) from 93.485%
when pulling c4956d3 on 2722-jdc-admin-destroy-user
into 2206c4a on main.

app/views/controllers/users/show/_profile.erb

- Goes to delete specified user

app/views/controllers/users/show/_profile.erb

JoeCohen added 2 commits February 18, 2025 14:55

Change Delete User link to a button

3c80386

Refine test for presence of button

ee2ecc2

- Tests that the button goes to the right place.

JoeCohen linked an issue Feb 18, 2025 that may be closed by this pull request

Destroy User UI #2722

Closed

Fix test for Delete User button

9559576

Matches (rather than equals) admin_user_path

JoeCohen commented Feb 18, 2025

View reviewed changes

app/views/controllers/users/show/_profile.erb Outdated Show resolved Hide resolved

JoeCohen requested a review from nimmolo February 18, 2025 23:35

JoeCohen added 2 commits February 18, 2025 15:45

Make test more precise

0c6ebe3

- Goes to delete specified user

Refine condition for showing Destroy User button

c061b93

nimmolo requested changes Feb 20, 2025

View reviewed changes

app/views/controllers/users/show/_profile.erb Outdated Show resolved Hide resolved

Use destroy_button helper instead of rolling my own

c4956d3

JoeCohen added the bug label Feb 20, 2025

JoeCohen self-assigned this Feb 20, 2025

JoeCohen merged commit 1ef089a into main Feb 21, 2025
8 checks passed

Provide feedback