Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box scopes params and methods - improved error reporting #2704

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Feb 6, 2025

Add useful UI error message for any missing PatternSearch params in north, south, east, west if any others are present, rather than dropping the other params silently. Also, automatically flop north and south if south > north.

Adds new tests.

@nimmolo nimmolo marked this pull request as ready for review February 6, 2025 08:57
@nimmolo nimmolo merged commit 28f052d into main Feb 6, 2025
6 checks passed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 93.38% (+0.003%) from 93.377%
when pulling dc84336 on nimmo-box-scopes-params-and-methods
into c1be379 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants