Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box scopes, params and methods #2694

Merged
merged 26 commits into from
Feb 6, 2025
Merged

Box scopes, params and methods #2694

merged 26 commits into from
Feb 6, 2025

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Feb 2, 2025 •
edited
Loading

This implements the in_box Query param for Observations and Locations, replacing the previous north, south, etc. params and enabling it to hand off directly to the scopes of the same name in the future.

nimmolo added 24 commits February 1, 2025 22:51
@nimmolo
Pass around Mappable::Box instead of nsew params
3134677
@nimmolo
Make Mappable::Box an ActiveModel class
e8089ea
@nimmolo
Lots of groovy stuff, but you cannot pass an instance as a Rails param
660b37e
@nimmolo
Revert stuff that was too model-y
edf19cd
@nimmolo
improved. som funky
c68a6f8
@nimmolo
Stop sending bounding box params to indexes. Send queries.
00a4cd7
@nimmolo
filtered_index_final_hook return query
9d49aa2
@nimmolo
Rework and proof methods of in_box
fb9a212
@nimmolo
Update map_helper.rb
38f7fc9
@nimmolo
Update map_helper.rb
8998c03 
Try to fix
@nimmolo
Update validation.rb
0dc219d
@nimmolo
Merge branch 'nimmo-validation-refactor' into nimmo-box-scopes-params…
761c700 
…-and-methods
@nimmolo
Merge branch 'main' into nimmo-box-scopes-params-and-methods
7e50c7d
@nimmolo
Merge branch 'nimmo-obs-in-box-rewrite' into nimmo-box-scopes-params-…
6acf811 
…and-methods
@nimmolo
Merge branch 'main' into nimmo-box-scopes-params-and-methods
310d9b1
@nimmolo
Update scopes.rb
df8f9e8
@nimmolo
Update observation.rb
5a5e52a
@nimmolo
Update maps_controller_test.rb
0ec8be8
@nimmolo
Fix ActiveModel validation for Box model
6a4948b
@nimmolo
Mappable::Box
5634f4b 
Add check for valid box
fix must_have_valid_bounds
@nimmolo
PatternSearch::Observation
7d0c9ae 
Validate box before sending
@nimmolo
Update map_helper.rb
1dec288 
Fix mapset_box_params
@nimmolo
Refactor expand, delta_lat/lng
de7d850
@nimmolo
Populate cols first
a696939
@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2025 •
edited
Loading

Coverage Status

coverage: 93.377%. remained the same
when pulling e246eb6 on nimmo-box-scopes-params-and-methods
into 825bab5 on main.

@nimmolo nimmolo marked this pull request as ready for review February 6, 2025 06:38
@nimmolo nimmolo merged commit c1be379 into main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimmolo @coveralls