Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite range scopes signatures like Query #2691

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Feb 1, 2025

Rewrites confidence, quality and rank range scopes closer to Query usage, adds tests for accuracy.


Info controller Site Stats image query change:

This is a minor but expensive query that grabs 6 recent images of confident observations having high image_votes. The images appear on the top of the info/site_stats page.

Rewriting the query here in AR because

  • it currently is the only Query lookup using two special params that will soon be sunsetted. (They are not used for AR queries.)
  • the current query casts a wide net and is very expensive; the new query only checks the last 4 months of images of confident observations and runs 4x faster.
  • it uses the new confidence scope, which had an untested bug previously.

@nimmolo nimmolo changed the title Nimmo observation and location scopes Rewrite range scopes signatures like Query Feb 1, 2025
@nimmolo nimmolo marked this pull request as ready for review February 1, 2025 09:40
@nimmolo nimmolo merged commit fb36863 into main Feb 1, 2025
6 checks passed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 93.317%. remained the same
when pulling f0059c5 on nimmo-observation-and-location-scopes
into 84e7859 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants