fix: Update emitted when order has not changed

Musare · Jun 15, 2024 · cfc22e9 · cfc22e9
1 parent 09f9237
commit cfc22e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 - Add option to only allow dragging when you click a handle element
 
+### Fixes
+
+- fix: Update emitted when order has not changed
+
 ## [v0.1.3] - 2022-12-07
 
 ### Changes

diff --git a/src/components/DraggableList.vue b/src/components/DraggableList.vue
@@ -202,15 +202,17 @@ const onDragEnd = () => {
     if (!window.draggingItem) return;
     const { itemIndex, itemListUuid, initialItemIndex, initialItemListUuid } =
         window.draggingItem;
-    if (itemListUuid === initialItemListUuid)
+    if (itemListUuid === initialItemListUuid) {
+        if (initialItemIndex === itemIndex) return;
+
         emit("update", {
             moved: {
                 oldIndex: initialItemIndex,
                 newIndex: itemIndex,
                 updatedList: data.value
             }
         });
-    else emit("update", {});
+    } else emit("update", {});
     delete window.draggingItem;
 };