Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph intersection and graph difference functions. #416

Open
wants to merge 57 commits into
base: develop
Choose a base branch
from

Conversation

jahandaniyal
Copy link
Collaborator

@jahandaniyal jahandaniyal commented Jun 21, 2019

Purpose

Fixes #415
Implements Basic Diff for Graphs functionality for two Graphs.

Example:
Fixes # .

Approach

How does this change address the problem?

Open Questions and Pre-Merge TODOs

  • Use github checklists. When solved, check the box and explain the answer.

Learning

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Blog Posts

ToDo :-

  • Graph visualization does not refresh sometimes.
  • Customize Grid layout for Diff.
  • Add Node popup like Graph Visualization canvas of graphs page.
  • Add support for query params
  • Separate compare_graph code from graph_page
  • Refine UI
  • Add documentation

adbharadwaj and others added 12 commits April 10, 2019 13:10
Implement graph intersection and graph difference function for two
graphs. Additionally, expose API Endpoints to serve requests from
GraphSpace.

Intersection and Difference are basic functionalities for graph
comparison. In this patch, only 2 graphs are being considered for
comparison.

Two new API endpoints - 1 for graphs compare page and another to
accept GET requests from GraphSpace UI. Do resource hungry computation
in PostGREs DB using SQLAlchemy ORM as much as possible. This helps in
improving performance as computation over large datasets is not
particularly efficient in Python when compared to RDMS. Serialise data
from PostGREs and send as JSON to GraphSpace.
@jahandaniyal jahandaniyal requested a review from adbharadwaj June 21, 2019 18:10
Add functionality for Graph Visualization.
Updates Nodes and Edges table to handle intersection and difference.
Fixes node/edge table refreshing bug.

Requires cose-bilkent plugin for Cytoscape.js
Cytoscape.js needs to be updated to at least ^3.2.0
Use both head_node and tail_node for edge comparison operations.
@jahandaniyal
Copy link
Collaborator Author

Popup feature blocked by this PR - #387
For the time being - I can change it locally (rename cy.Target -> cy.target).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants