GraphSpace Email Lists #393
Conversation
Adding a pull request template to standardize the description of the proposed changes from contributors. Project contributors will automatically see the template's contents in the pull request body. More details can be found [here](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
| @@ -0,0 +1,20 @@ | |||
| ## Purpose | |||
There was a problem hiding this comment.
Can you merge the latest changes to develop branches on Main repo?
There was a problem hiding this comment.
I need to merge validates email address by sending a confirmation email to users, before merging email lists. Do you mind to review pull#238 before I merge it? Thank you.
| @@ -23,6 +23,10 @@ class User(IDMixin, TimeStampMixin, Base): | |||
| email = Column(String, nullable=False, unique=True, index=True) | |||
| password = Column(String, nullable=False) | |||
| is_admin = Column(Integer, nullable=False, default=0) | |||
| user_account_status = Column(Integer, nullable=False, default=0) | |||
There was a problem hiding this comment.
Can you add documentation about the newly added fields? Since account status is integer what are the possible values and what they mean?
applications/users/models.py
Outdated
| @@ -23,6 +23,10 @@ class User(IDMixin, TimeStampMixin, Base): | |||
| email = Column(String, nullable=False, unique=True, index=True) | |||
| password = Column(String, nullable=False) | |||
| is_admin = Column(Integer, nullable=False, default=0) | |||
| user_account_status = Column(Integer, nullable=False, default=0) | |||
| email_confirmation_code = Column(String, nullable=False, default=0) | |||
| email_list_announcement = Column(String, nullable=False, default=0) | |||
There was a problem hiding this comment.
It is unclear what email_list_announcement field does?
applications/users/models.py
Outdated
| user_account_status = Column(Integer, nullable=False, default=0) | ||
| email_confirmation_code = Column(String, nullable=False, default=0) | ||
| email_list_announcement = Column(String, nullable=False, default=0) | ||
| email_list_user = Column(String, nullable=False, default=0) |
static/js/main.js
Outdated
|
|
||
|
|
||
| if (announcement_checked.checked == true) { | ||
| email_list_announcement = '1'; |
There was a problem hiding this comment.
Why are we storing 1 as a string?
There was a problem hiding this comment.
Because in models.py I defined the data type of email_list as String. Of course, we can change it to boolean or integer if necessary. '1' means users choose to join the corresponding email_list_anncouncement or email_list_user. '0' means they won't join.
There was a problem hiding this comment.
- It should be either Integer or Boolean. I would say Boolean.
- What is the difference between email_list_anncouncement and email_list_user?
There was a problem hiding this comment.
- Ok，I will change to Boolean
- GraphSpace administrators post announcements to announcement email list. Users use user email list to post messages and discuss questions.
static/js/main.js
Outdated
| } | ||
|
|
||
| if (user_checked.checked == true) { | ||
| email_list_user = '1'; |
Change data type of email_list_announcement/user to integer
Change data type of email_list_announcemnt/user to integer
|
Files need to configure the domain name. For example, if you changed your domain name from graphspacetest.com to graphspace.org, you need to change the corresponding domain name in the files.
|
Purpose
Built announcements and users email lists to post important announcements and allow users to communicate with each other.
Approach
Invoke GNU Mailman3 REST API.
Open Questions and Pre-Merge TODOs
Learning
Mailman 3 suite documents
Install and Configure Mailman3 Suite for GraphSpace
Configure Hyperkitty and Edit Welcome Messages
Blog Posts