-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout compatibility feature #390
Open
jahandaniyal
wants to merge
30
commits into
Murali-group:develop
Choose a base branch
from
jahandaniyal:layout_compatibility_feature
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Layout compatibility feature #390
jahandaniyal
wants to merge
30
commits into
Murali-group:develop
from
jahandaniyal:layout_compatibility_feature
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a pull request template to standardize the description of the proposed changes from contributors. Project contributors will automatically see the template's contents in the pull request body. More details can be found [here](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/).
…phSpace into version_feature
fixes #383 @jahandaniyal can you confirm? |
@adbharadwaj - The fix works but its not implemented for all the tables yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This patch implements Layout Compatibility Check- Allow users to check whether a layout is compatible with a particular Graph Version.
Feature Details
GraphSpace allows its users to create custom layouts and with the addition of Version Control feature there could be scenarios where a particular user created layout may or may not be compatible with a given version of the Graph. This patch will allow users to check whether a layout is compatible or not.
The following features are available in the Layout Compatibility functionality:
Layout Selection Dropdown Menu
The Layout Dropdown menu allows Users of GraphSpace to quickly select and apply the Layouts.
There are 3 the broad sections to the Dropdown Menu -
Layout Compatibility Status Bar
The ticker bar used for notifying the User are of 3 different Colors corresponding to 3 different situations -
Checking Layout Compatibility
Anytime a User tries to apply a Layout on a particular version of the Graph, GraphSpace checks the layout compatibility status. Based on the layout compatibility status, 3 scenarios may arise -
Layout is compatible
If the layout is compatible with the current version of the Graph then it simply applied to the Graph. The User will not receive any Error or Warning Notification in the Status Bar.
Layout is not compatible
If the layout is not compatible with the current version of the Graph then the User is notified about this issue in the Layout Compatibility Status Bar. The status bar turns red to notify the User that there are
Errors
in the Layouts. The User needs to fix the errors before they can apply the layout.Layout Compatibility is unknown
If the compatibility of the Layout with the current version of the Graph could not be determined then the User is notified about this issue in the Layout Compatibility Status Bar. The status bar turns Yellow to warn the User about the unknown layout compatibility status. The User can run a compatibility check to determine whether the layout is compatible or not.
The layout compatibility check will return either of these 2 results -
Green
status bar suggesting that the Layout is compatible and can be applied. The status is then stored in the database to allow Users to skip the Layout Compatibility checking step next time they want to use this layout.Fixing Layout Compatibility Errors
Users can add style information for nodes & edges by clicking on the Add Style in
Nodes/Edges without Style information
Table.The status bar displays the number the elements which require attention of the User. This status bar is updated in real-time as the User adds Style for the missing elements.
When the User has successfully added style for all the missing elements then the Status bar will be updated based on the following 2 conditions -
Nodes/Edges without Style information
&Unknown Nodes & Edges
Tables are empty - In this case the Status bar will disappear from the screen suggesting that all issues have been resolved.Unknown Nodes & Edges
Table is not empty - In this case the Status bar changes toWarning
to let the User know that there are additional elements in the Layouts which are not present in the Graph.Demonstration
LOOM Video demo
Dal tests
Tested Create, Read, Update and Delete operations on
Layout-to-Graph-Version
table.Will add more tests as more features are added to Layout Compatibility module.
Open Questions and Pre-Merge TODOs
@jahandaniyal
Learning
http://gsoc18.blogspot.com/
Links to blog posts, patterns, libraries or addons used to solve this problem
Blog Posts