Add tools to select edges by arrow-shapes, line-color and line-style #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution, @HitRam. Adding selection by line style will also be valuable. Please implement this selection criterion. |
HitRam
changed the title
|
@tmmurali, I also implemented selection by line-style. |
adbharadwaj
requested changes
Feb 7, 2018
static/js/graphs_page.js
Outdated
| @@ -1332,6 +1332,9 @@ var graphPage = { | |||
| original_opacity: {}, | |||
| undoRedoManager: null, | |||
| init: function () { | |||
| cytoscapeGraph.hideGraphInformation(graphPage.cyGraph); | |||
There was a problem hiding this comment.
Why do we need to hide and show graph information?
static/js/graphs_page.js
Outdated
| @@ -2736,6 +2862,7 @@ var cytoscapeGraph = { | |||
| /* | |||
| Function to Show information about the graph that the layout editor hid from the users. | |||
| */ | |||
| console.log(cy.style().selector('node')); | |||
There was a problem hiding this comment.
Can you remove the log.
There was a problem hiding this comment.
Yeah sure! Actually I was initially making changes on master branch and these lines were already there.
static/js/graphs_page.js
Outdated
| @@ -1708,6 +1832,8 @@ var graphPage = { | |||
| }); | |||
|
|
|||
| $('#nodeLabel').on('input', function (e) { | |||
| console.log(!_.isEmpty($('#nodeLabel').val())); | |||
There was a problem hiding this comment.
Comment out the console log.
|
@adbharadwaj I have changed as requested. Initially I was making changes in master branch and those logs were already there so didn't notice while switching the branches. |
adbharadwaj
approved these changes
Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added tools to select edges by arrow-shapes and line-color.
Should I also add an option to select it by line-style?
This PR refers to #308