-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular switches #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had some dumb merging issues @Yemeen so I'd appreciate you checking this out for me :D |
Sorry, not ready yet. Just was staring at the picture and it's drawing things in the wrong places. I'll fix it and re-request. |
Yemeen
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after that lgtm
…nce that was getting similarly unweildy
Yemeen
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a drawing ability to see the angles where two vertices switch order. This is useful for some theoretical projects coming down the pipe.
Added a function to the EmbeddedGraph class called
get_all_angles
which gets all the angles of the line normal to the line segment between every pair of vertices. Added an option to the plotting command,angle_labels_circle=True
, which will draw these things on a circle around the graph (as long as it's not too big). Added a jupyter notebook with basic examples of these calledTutorial-ExactECT.ipynb
.Motivation and Context
Fun to play with for future projects.
How has this been tested?
Added a small test for the output of the angles function.
Types of changes
Checklist
make clean
)make html
)pyproject.toml
file.make tests
)