Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular switches #47

Merged
merged 16 commits into from
Jan 22, 2025
Merged

Circular switches #47

merged 16 commits into from
Jan 22, 2025

Conversation

lizliz
Copy link
Contributor

@lizliz lizliz commented Jan 18, 2025

Description

I added a drawing ability to see the angles where two vertices switch order. This is useful for some theoretical projects coming down the pipe.

Added a function to the EmbeddedGraph class called get_all_angles which gets all the angles of the line normal to the line segment between every pair of vertices. Added an option to the plotting command, angle_labels_circle=True, which will draw these things on a circle around the graph (as long as it's not too big). Added a jupyter notebook with basic examples of these called Tutorial-ExactECT.ipynb.

image

Motivation and Context

Fun to play with for future projects.

How has this been tested?

Added a small test for the output of the angles function.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (make clean)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (make html)
  • I have incremented the version number in the pyproject.toml file.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (make tests)

@lizliz lizliz requested a review from Yemeen January 18, 2025 11:23
@lizliz
Copy link
Contributor Author

lizliz commented Jan 18, 2025

I had some dumb merging issues @Yemeen so I'd appreciate you checking this out for me :D

@lizliz lizliz marked this pull request as draft January 18, 2025 11:49
@lizliz
Copy link
Contributor Author

lizliz commented Jan 18, 2025

Sorry, not ready yet. Just was staring at the picture and it's drawing things in the wrong places. I'll fix it and re-request.

@lizliz lizliz marked this pull request as ready for review January 18, 2025 15:07
@lizliz
Copy link
Contributor Author

lizliz commented Jan 21, 2025

image
Now the drawing looks like this. Also added some better tests.

Copy link
Member

@Yemeen Yemeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after that lgtm

@lizliz lizliz requested a review from Yemeen January 22, 2025 21:17
@lizliz lizliz merged commit 1f85e0e into main Jan 22, 2025
3 checks passed
@Yemeen Yemeen deleted the circular_switches branch January 22, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants