Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit scaling Feature #21

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Unit scaling Feature #21

merged 5 commits into from
Aug 8, 2024

Conversation

Yemeen
Copy link
Member

@Yemeen Yemeen commented Aug 7, 2024

Description

Added unit scaling to coordinates and a center function

Motivation and Context

Requested in #19

How has this been tested?

added unit tests for rescaling and finding the center

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [ x] My code follows the code style of this project. (make clean)
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly. (make html)
  • [ x] I have incremented the version number in the pyproject.toml file.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed. (make tests)

@Yemeen Yemeen requested a review from lizliz as a code owner August 7, 2024 21:17
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous!

@lizliz lizliz merged commit eaa5184 into main Aug 8, 2024
3 of 4 checks passed
@Yemeen Yemeen deleted the unit-scaling branch August 8, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants