Properly manage timestamps of profile files #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before now, when switching profiles, all the timestamps of the moved files would be updated. This causes `make` to re-run for every profiled run even though the same run is repeatedly executed. To avoid this, Kerblam! now makes a file with the name of the last-used profile in `~/.cache/kerblam/...`. The filename is the hash of the project path, so that each project gets one cache file. If kerblam detects that the same profile was used twice in a row, it skips updating the timestamps. If a normal run is executed, this cache is deleted and all the input files are re-touched (as if they were moved) to re-trigger the pipeline. This should prevent having to `data clean` every time a profile is switched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before now, when switching profiles, all the timestamps of the moved files would be updated. This causes
maketo re-run for every profiled run even though the same run is repeatedly executed.To avoid this, Kerblam! now makes a file with the name of the last-used profile in
~/.cache/kerblam/.... The filename is the hash of the project path, so that each project gets one cache file.If kerblam detects that the same profile was used twice in a row, it skips updating the timestamps. If a normal run is executed, this cache is deleted and all the input files are re-touched (as if they were moved) to re-trigger the pipeline. This should prevent having to
data cleanevery time a profile is switched.This PR fixes issue #40.
TODO
Before merging, tick all of these boxes:
cargo test -- --include-ignoredpasses without errors or warnings.