Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code and add tiny features #60

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Refactor code and add tiny features #60

merged 10 commits into from
Feb 5, 2024

Conversation

MrHedmad
Copy link
Owner

@MrHedmad MrHedmad commented Feb 5, 2024

This pull requests adds the following:

  • Refactored some code:
    • Split main.rs into lib.rs and main.rs in preparation for integration tests.
    • Moved some functions around to better reflect their role;
    • Added some docstrings;
    • Removed some useless configurations (like temporary_data_dir from the TOML) and functions;
    • Updated Cargo.lock and removed some useless depenencies.
  • Add markdown rendering of pipe descriptions obtained by kerblam run pipe --desc;
  • Fix Allow default dockerfile for kerblam run #13 - a default.dockerfile is now detected and used if no specific dockerfile can be found for a pipe. The emoji in the pipes list for such pipes is a smaller fish (:fish:) instead of a whale (:whale:) to differentiate them better.

TODO

Before merging, tick all of these boxes:

  • cargo check passes without errors or warnings.
  • @all-contributors is made aware of this PR.

@MrHedmad MrHedmad merged commit 0728edb into main Feb 5, 2024
5 checks passed
@MrHedmad MrHedmad deleted the dev branch February 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow default dockerfile for kerblam run
1 participant