Add experimental windows compatibility #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powershell does not support running files (with `-File`) that do not end in the `.ps1` extension. This is obviously dumb for interoperability: you'd have kerblam shell workflows working on linux but not on windows, and vice-versa. A workaround is to use `Invoke-Command`, and source the file inside the "CommandBlock" that Invoke-Command supports. This is fine, but then if you find out that `Invoke-Command` is *not* a program, *it's a powershell internal "magic" command*. So when Kerblam! tries to spawn the `Invoke-Command` executable it fails. So, we combine both approaches: we use `powershell -Command` to spawn a powershell, and pass a command to it. This command is `Invoke-Command`, which takes care of reading the content of whatever workflow file we are using, and execute it (in the current shell, so our sub-shell). Fuck me!
|
It is currently unknown if tests pass on Windows, as I do not have a system setup to run them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds (tentative) support for the Windows architecture. This mainly impacts filesystem interactions (e.g. the
MetadataExtmodule that we need to get file sizes) and the execution policies (i.e. supporting powershell instead of bash).This would fix #48.
TODO
Before merging, tick all of these boxes:
cargo test -- --include-ignoredpasses without errors or warnings.CHANGELOG.mdhas been updated to reflect these changes.