Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-fetcheable remote files #113

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Allow non-fetcheable remote files #113

merged 4 commits into from
Nov 22, 2024

Conversation

MrHedmad
Copy link
Owner

@MrHedmad MrHedmad commented Nov 22, 2024

This PR adds the ability for Kerblam! to allow non-fetcheable remote files.
This is done by specifying "_" as the URL, so that Kerblam! will skip the GET request, but still treat the local file as remote for all other purposes.
This required some restructuring of how RemoteFile works under the hood, and how kerblam.toml is parsed.

TODO

Before merging, tick all of these boxes:

  • cargo test -- --include-ignored passes without errors or warnings.
  • The CHANGELOG.md has been updated to reflect these changes.
  • Documentation is updated that reflect these changes, or this PR changes nothing that is reflected in the docs.
  • @all-contributors is made aware of this PR, or I am already in the all contributors list.

@MrHedmad MrHedmad merged commit cace383 into main Nov 22, 2024
6 checks passed
@MrHedmad MrHedmad deleted the non_fetcheable_remotes branch November 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant