Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kerblam data clean preserves empty directories #33

Closed
MrHedmad opened this issue Jan 8, 2024 · 1 comment
Closed

kerblam data clean preserves empty directories #33

MrHedmad opened this issue Jan 8, 2024 · 1 comment
Labels
feat New feature or request good first issue Good for newcomers

Comments

@MrHedmad
Copy link
Owner

MrHedmad commented Jan 8, 2024

The data clean command only cleans up the files, not the directories.

This might not be desirable if someone has some particular structure of the data directory (like internal symlinks), but it could be a sensible default.

I suggest adding a --keep-dirs flag to kerblam data clean and keeping only the eventual input/output/temporary/intermediate directories when cleaning, removing all the others.
@MrHedmad MrHedmad added feat New feature or request good first issue Good for newcomers labels Jan 8, 2024
@MrHedmad
Copy link
Owner Author

Fixed in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrHedmad