Offsetcals adc1 fix #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #18. Follows datasheet section 9.4.9.8 Calibration Command Procedure.
NOTE: I didn't fix every cal procedure. This also depends on some changes from PR #21.
calibrateSysOffsetADC1(shorted1,shorted2,waitTime=0). (set continuous mode, then start shorted conversion BEFORE calibrating)calibrateSelfOffsetADC1(waitTime=0). (set continuous mode, then start floating conversion BEFORE calibrating)Only tested with ADS1262. Seems to work well! Strangely, selfOffset gives me results that are further away from zero once the inputs are shorted but really stable - I suppose the extra resistance of my breakout? I'm using the mikroe click adc13. Maybe someone else can test and let me know if this is good?