Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix download authentication feeds #867

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jan 7, 2025

Summary:
Part of #783

Expected behavior:

Flip implementation of authentication type 1 and 2

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Jan 7, 2025 that may be closed by this pull request
@qcdyx qcdyx changed the title 783 fix download authentication feeds feat: fix download authentication feeds Jan 27, 2025
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation LGTM. However, it doesn't completely close the issue #783. This PR only addresses the first point of the proposed solution.

@davidgamez davidgamez merged commit 4a0ba9f into main Feb 3, 2025
3 checks passed
@davidgamez davidgamez deleted the 783-fix-download-authentication-feeds branch February 3, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix download authentication feeds
2 participants