Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old character or NPC is missing a cutscene art or a sound file? Post here #2

Open
MizaGBF opened this issue Jan 1, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MizaGBF
Copy link
Owner

MizaGBF commented Jan 1, 2024

Title says it all.
If you notice a npc or character is missing an image under the Scene Arts category, just post here the ID or the URL(s) of the image(s).
(URLs might be more useful in case those arts are due to me missing the corresponding strings, such as _sad.png, _laugh.png or whatever else they might add).
Same thing if you notice a missing sound file associated with a NPC, characters or outfits.
Thanks in advance.

EDIT: If you're passing by and don't have a github account, you can notify me via this google form

@MizaGBF MizaGBF self-assigned this Jan 1, 2024
@MizaGBF MizaGBF added enhancement New feature or request help wanted Extra attention is needed labels Jan 1, 2024
@MizaGBF MizaGBF pinned this issue Jan 1, 2024
@Yakkak
Copy link

Yakkak commented Jan 15, 2024

Hello! I came here to report Orologia's missing Daph form as seen on the other art assets (ID: 3992764000), would you be able to add them to the page?

The current page only has sprites of one form, and I'm certain there's more sprites tied to the other form but I'm terribly unfamiliar with how gbf's assets are handled so I apologize for not having anything else to go off of, and I also apologize in advance if this isn't the right place/format to report the issue!

Thank you!

@MizaGBF
Copy link
Owner Author

MizaGBF commented Jan 16, 2024

I took a look:
3992764000 seems to be the Orologia NPC which appeared in Arulumaya's fate episode, which didn't have the female form yet.
"And You" reuses those assets, along with a new NPC entry for the female form: 3992868000.
So, they are separate. Nothing I can do about it, sadly.

@Yakkak
Copy link

Yakkak commented Jan 16, 2024

Oh...! No worries, you actually still helped me since I wasn't able to find that version and had hoped to find the assets for it, so thank you very much!

@MizaGBF MizaGBF changed the title Old character or NPC is missing a cutscene art? Post here Old character or NPC is missing a cutscene art or a sound file? Post here Feb 12, 2024
@RaccoonSmores
Copy link

Hello! While looking for something, I realized it seems event Seox's story sprites are missing. ID 3991666000

I might be missing a few but here are image urls I found:
1 2 3 4 5 6 7 8 9 10 11 12

I don't know if you archive these, but just in case, listing these few event art images that also seem to be missing:
ID scene_evt200304
urls: 1 2 3 4 5 6 7 8 9

ID scene_chr599
urls: 1 2 3 4 5 6

@MizaGBF
Copy link
Owner Author

MizaGBF commented Apr 8, 2024

For Seox:
I see a few strings I wasn't aware of. The problem is they seem exclusive to him and adding them will likely be a heavy burden for the update process on the long run (because the update will have to check those for every characters). I'll try to think of a solution.

For Seeds of Redemption:
I'm adding it right now. I'll also check all other events tagged "without art", in case more is missing.

For the last part:
scene_chr599 indicates it's from a fate episodes. I can't add those, for now. There are many issues for which I don't have a solution, plus the extra load it would cause.

Thank you for your detailed report, however. It's very helpful.

EDIT:
Seox has been added, I changed the system I was using. I'll see how it goes.

@RaccoonSmores
Copy link

I completely understand the complications, avoiding extra load, and future proofing the coding, so was very surprised to see the Seox assets already added in! Thank you for such the hard work! Both the asset and animation sites have been a godsend to me, and no words can express my gratitude. I'm also happy I could help in some way!

But I didn't come to merely reply. I did a quick look through for all my other party members yesterday, and noticed Grand!Nehan is missing a few scene art strings when compared to both his Valentine NPC versions.

Grand!Nehan ID: 3040341000
_laugh3 / _laugh3_up
_laugh4 / _laugh4_up

For quick reference: Grand!Nehan's page vs one of Valentine NPC Nehan's

@MizaGBF
Copy link
Owner Author

MizaGBF commented Apr 9, 2024

I double checked, those file names are picked up by the script, so no reasons they should be missing.
I've been running a full check of every npc/chara/skins after modifying the script and around 60%~ of the chara are left.
They should be listed in the next 24h.
I'll try on Nehan, to be sure.
EDIT: It works.

@RaccoonSmores
Copy link

That does sound odd that the strings weren't picked up, but happy to hear the modifications and the full check all worked out. Thank you again!! Amazed at how quick you got it all fixed!

@MizaGBF
Copy link
Owner Author

MizaGBF commented Apr 10, 2024

That does sound odd that the strings weren't picked up, but happy to hear the modifications and the full check all worked out. Thank you again!! Amazed at how quick you got it all fixed!

Because I likely added them at some point and didn't bother updating the whole list again, it takes ages to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants