storage fix last snapshot non empty assertions

MixinNetwork · Dec 29, 2024 · d785da1 · d785da1
1 parent f8caf5b
commit d785da1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/storage/badger_test.go b/storage/badger_test.go
@@ -23,9 +23,6 @@ func TestBadger(t *testing.T) {
 	require.NotNil(store)
 	defer store.Close()
 
-	snap, _ := store.LastSnapshot()
-	require.Nil(snap)
-
 	err = store.snapshotsDB.Update(func(txn *badger.Txn) error {
 		return txn.Delete([]byte("key-not-found"))
 	})

diff --git a/storage/badger_topology.go b/storage/badger_topology.go
@@ -145,9 +145,6 @@ func (s *BadgerStore) LastSnapshot() (*common.SnapshotWithTopologicalOrder, *com
 	if err != nil {
 		panic(err)
 	}
-	if topo == 0 && len(snaps) == 0 {
-		return nil, nil
-	}
 	if len(snaps) != 1 {
 		panic(topo)
 	}

diff --git a/storage/transaction_test.go b/storage/transaction_test.go
@@ -25,9 +25,6 @@ func TestTransaction(t *testing.T) {
 	store, _ := NewBadgerStore(custom, root)
 	defer store.Close()
 
-	last, _ := store.LastSnapshot()
-	require.Nil(last)
-
 	gns, err := common.ReadGenesis("../config/genesis.json")
 	require.Nil(err)
 	rounds, snapshots, transactions, err := gns.BuildSnapshots()
@@ -84,6 +81,10 @@ func TestTransaction(t *testing.T) {
 	require.Nil(err)
 	require.Equal("365553.00000000", balance.String())
 
+	last, _ := store.LastSnapshot()
+	require.NotNil(last)
+	require.Equal(last.PayloadHash(), snapshots[len(snapshots)-1].PayloadHash())
+
 	round, _ := store.ReadRound(rounds[0].NodeId)
 	require.Equal(uint64(1), round.Number)
 	snap := &common.Snapshot{
@@ -143,6 +144,10 @@ func TestTransaction(t *testing.T) {
 	require.Nil(err)
 	require.Equal("365562.00000000", balance.String())
 
+	last, _ = store.LastSnapshot()
+	require.NotNil(last)
+	require.Equal(last.PayloadHash(), topo.PayloadHash())
+
 	ver, ss, err := store.ReadWithdrawalClaim(submit.AsVersioned().PayloadHash())
 	require.Nil(err)
 	require.Equal("", ss)
@@ -207,6 +212,10 @@ func TestTransaction(t *testing.T) {
 	oldnCS, oldnRB := store.readConsensusSnapshot(ncs)
 	require.Equal(ncs.PayloadHash(), oldnCS.PayloadHash())
 	require.Nil(oldnRB)
+
+	last, _ = store.LastSnapshot()
+	require.NotNil(last)
+	require.Equal(last.PayloadHash(), topo.PayloadHash())
 }
 
 func (s *BadgerStore) readConsensusSnapshot(snap *common.Snapshot) (*common.Snapshot, *crypto.Hash) {