bump version to v0.18.22 #227
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
util/base58/base58_test.go#L12
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58bench_test.go#L11
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58check_test.go#L10
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58_test.go#L85
Duplicate words (failed) found (dupword)
|
|
lint:
util/base58/base58check_test.go#L55
do not compare errors directly "err != base58.ErrChecksum", use "!errors.Is(err, base58.ErrChecksum)" instead (err113)
|
|
lint:
util/base58/base58check_test.go#L64
do not compare errors directly "err != base58.ErrInvalidFormat", use "!errors.Is(err, base58.ErrInvalidFormat)" instead (err113)
|
|
lint:
util/base58/base58_test.go#L15
stringTests is a global variable (gochecknoglobals)
|
|
lint:
util/base58/base58_test.go#L32
invalidStringTests is a global variable (gochecknoglobals)
|
|
lint:
util/base58/base58_test.go#L50
hexTests is a global variable (gochecknoglobals)
|
|
lint:
util/base58/base58bench_test.go#L15
raw5k is a global variable (gochecknoglobals)
|
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
config/reader.go#L14
var-naming: const KernelNetworkId should be KernelNetworkID (revive)
|
|
lint:
storage/badger_validation.go#L73
increment-decrement: should replace total += 1 with total++ (revive)
|
|
lint:
storage/badger_validation.go#L88
increment-decrement: should replace invalid += 1 with invalid++ (revive)
|
|
lint:
storage/badger_validation.go#L108
increment-decrement: should replace invalid += 1 with invalid++ (revive)
|