Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to view their bookmarks in the Search modal #52

Open
MitchellMarkGeorge opened this issue Jul 24, 2022 · 2 comments
Open

Allow users to view their bookmarks in the Search modal #52

MitchellMarkGeorge opened this issue Jul 24, 2022 · 2 comments
Labels
enhancement New feature or request L Large Task UI UX
Milestone

Comments

@MitchellMarkGeorge
Copy link
Owner

Is your feature request related to a problem? Please describe.
In line with #36, one of the features that is important for 1.0 is the ability to view and search their bookmarks right from the Search modal (Similar to #51).

Describe the solution you'd like
Once #36 is done, there should be a section in the sidebar for history. A SearchMode should also be created for BOOKMARKS. When the currentSearchMode is set to the HISTORY SearchMode, the React component should send a message to the background script requesting for the data (just like what we do for Data). Just like fetching the TabData, we will probably have to create our own TypeScript type with only guaranteed and necessary fields (can be named something like BookmarkData). There should also be a specific ListItem component (like ActionListItem) dedicated to rendering this type.

Describe alternatives you've considered
N/A

Additional context
As said earlier, this ticket relies on #36 to be implemented. If you need any assistance, please feel free to reach out!

@MitchellMarkGeorge MitchellMarkGeorge added enhancement New feature or request UX L Large Task UI labels Jul 24, 2022
@MitchellMarkGeorge MitchellMarkGeorge added this to the 1.0 milestone Jul 24, 2022
@MitchellMarkGeorge
Copy link
Owner Author

For the list items, use FcBookmark for the icons

@MitchellMarkGeorge MitchellMarkGeorge modified the milestones: 1.0, Relaunch Apr 5, 2023
@MitchellMarkGeorge
Copy link
Owner Author

Moving this over to Relaunch milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request L Large Task UI UX
Projects
None yet
Development

No branches or pull requests

1 participant