-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto merge for pre commit and dependabot in a CI job #24
Add auto merge for pre commit and dependabot in a CI job #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to our community 🤗 and thank you for your first contribution.
As a first time contributor please make sure to review our contribution guidelines ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a CI workflow that build/lint the project?
I assume this would be steps to perform before approve / merge, so it becomes something like:
Is it worth looking into reusable workflows (have you done that before?), it seems like a good way to avoid code duplication but is some more work to set up: |
Indeed. but the approve and merge is done by your current action. example:
|
Reusable workflows could be usefull, but often i do not see them used because everyone wants control over there pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b100dff
to
122af05
Compare
8d1be58
to
b9b6158
Compare
b9b6158
to
d843223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
Add a CI job to auto merge updates done by dependabot and pre-commit. Merges for dependabot are only done if minor or patch. For pre-commit it updates everything, as we don't have that level of control.
Resolves #
https://github.com/orgs/MinBZK/projects/7?pane=issue&itemId=65105178
Checklist
Please check all the boxes that apply to this pull request using "x":
Most changes are GitHub actions and those can not be tested locally. Pre-commit has been tested locally.