Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automerge #18

Merged
merged 2 commits into from
May 27, 2024
Merged

Enable automerge #18

merged 2 commits into from
May 27, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented May 27, 2024 •
edited
Loading

Description

It takes some time to merge all PRs. Enable automerge for patch versions

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog requested a review from a team as a code owner May 27, 2024 07:09
anneschuth
anneschuth previously approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Curious if this works though, given that we require at least 1 review?

@berrydenhartog
Copy link
Member Author

LGTM

Curious if this works though, given that we require at least 1 review?

I am also curious. It should enable automerge. But we also have a requirement that a codeowner needs to review.

@berrydenhartog berrydenhartog force-pushed the dependabot-automation branch from b7c89c5 to b993944 Compare May 27, 2024 07:22
@berrydenhartog berrydenhartog enabled auto-merge May 27, 2024 07:25
@berrydenhartog berrydenhartog merged commit 83e7790 into main May 27, 2024
4 checks passed
@berrydenhartog berrydenhartog deleted the dependabot-automation branch May 27, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berrydenhartog @anneschuth