sprintf, sprintl, sprinti library #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanRuzavin
reviewed
Apr 11, 2025
IvanRuzavin
reviewed
Apr 11, 2025
platform/sprint/lib/src/sprint.c
Outdated
|
|
||
| // ------------------------------------------------------------- PRIVATE MACROS | ||
|
|
||
| // TODO |
There was a problem hiding this comment.
Was it left here by accident? If so, should be removed.
IvanRuzavin
reviewed
Apr 11, 2025
platform/sprint/lib/include/sprint.h
Outdated
| * @param ... Additional arguments to be formatted and inserted into the resulting string. | ||
| * @return The number of characters written, excluding the null terminator. | ||
| */ | ||
| int sprintf_me(char *str, const char *format, ...); |
There was a problem hiding this comment.
All "(" symbols should be followed with a space and all ")" symbols should have space before them in function declarations and in the code. Should be fixed in all header and source files. In macros and comments it can be left without spaces.
IvanRuzavin
requested changes
Apr 11, 2025
|
Changelog should be placed in 2.14.4 folder, not 2.14.4/new_hw |
Co-authored-by: Ivan Ruzavin <ivan.ruzavin@mikroe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.