Index "change this week" showing 0 when CP on components has moved #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping this - small changes and I'd love it to get to prod today if possible. @lsabor could you take a look? |
lsabor
reviewed
Jan 30, 2025
Comment on lines
7
to
13
| { questionId: 31688, weight: -12 }, | ||
| { questionId: 31689, weight: 12 }, | ||
| { questionId: 31707, weight: 10 }, | ||
| { questionId: 31709, weight: 9 }, | ||
| { questionId: 34453, weight: 9 }, | ||
| // { postId: 27797, weight: 9 }, // currently missing on prod | ||
| { questionId: 31710, weight: 11 }, | ||
| { questionId: 31711, weight: -8 }, |
There was a problem hiding this comment.
Not for this PR, but we should really move away from hard coding any question / post IDs in the codebase as it won't be compatible with new instances. Just keep an eye on this going forward.
There was a problem hiding this comment.
Thanks - we'll be changing this soon, discuss next week: #2080
Nevermind you literally commented at the same moment I posted this. Amazing, thank you! |
ncarazon
force-pushed
the
fix/index-change-this-week-showing-0-when-cp-on-components-has-moved
branch
from
2398bb6 to
e42104a
Compare
ncarazon
deleted the
fix/index-change-this-week-showing-0-when-cp-on-components-has-moved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2078