quickfix build_forecasts tweaks for consistency (#1860)

Metaculus · Dec 31, 2024 · 3b50a86 · 3b50a86
1 parent 26e4280
commit 3b50a86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/questions/services.py b/questions/services.py
@@ -76,7 +76,9 @@ def build_question_forecasts(
     )[aggregation_method]
 
     # overwrite old history with new history, minimizing the amount deleted and created
-    previous_history = question.aggregate_forecasts.filter(method=aggregation_method)
+    previous_history = question.aggregate_forecasts.filter(
+        method=aggregation_method
+    ).order_by("start_time")
     to_overwrite, to_delete = (
         previous_history[: len(aggregation_history)],
         previous_history[len(aggregation_history) :],

diff --git a/utils/the_math/aggregations.py b/utils/the_math/aggregations.py
@@ -456,7 +456,11 @@ def get_aggregation_history(
     full_summary: dict[AggregationMethod, list[AggregateForecast]] = dict()
 
     # get input forecasts
-    forecasts = question.user_forecasts.order_by("start_time").select_related("author")
+    forecasts = (
+        Forecast.objects.filter(question_id=question.id)
+        .order_by("start_time")
+        .select_related("author")
+    )
 
     if user_ids:
         forecasts = forecasts.filter(author_id__in=user_ids)