Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Remove duplicate CAIP types #3071

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 5, 2025

This removes duplicate CAIP types that were moved to @metamask/utils. We were already using the @metamask/utils types in most places.

Closes #3043.

Breaking changes

  • The following functions, values, types, and structs were removed from @metamask/snaps-utils:
    • CHAIN_ID_REGEX
    • ACCOUNT_ID_REGEX
    • ACCOUNT_ADDRESS_REGEX
    • parseChainId
    • parseAccountId
    • LimitedString
    • ChainIdStringStruct
    • ChainIdStruct
    • AccountIdStruct
    • AccountIdArrayStruct
    • AccountAddressStruct
    • AccountAddress
    • ChainStruct
    • Chain
    • NamespaceStruct
    • Namespace
    • NamespaceIdStruct
    • NamespaceId
    • isNamespaceId
    • isChainId
    • isAccountId
    • isAccountIdArray
    • isNamespace

@Mrtenz Mrtenz force-pushed the mrtenz/remove-duplicate-caip-types branch from 1824c74 to 136115e Compare February 6, 2025 09:44
@Mrtenz Mrtenz marked this pull request as ready for review February 6, 2025 09:44
@Mrtenz Mrtenz requested a review from a team as a code owner February 6, 2025 09:44
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (3fa49bd) to head (c70a4df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3071      +/-   ##
==========================================
- Coverage   94.86%   94.86%   -0.01%     
==========================================
  Files         506      505       -1     
  Lines       11128    11088      -40     
  Branches     1704     1700       -4     
==========================================
- Hits        10557    10519      -38     
+ Misses        571      569       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz force-pushed the mrtenz/remove-duplicate-caip-types branch from 136115e to 3c8aaec Compare February 6, 2025 12:29
@Mrtenz Mrtenz merged commit 9898fcd into main Feb 7, 2025
168 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-duplicate-caip-types branch February 7, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CAIP types definitions in favor of @metamask/utils types
2 participants