Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests for the Snap UI rendering system #3060

Closed
FrederikBolding opened this issue Feb 4, 2025 · 0 comments · Fixed by MetaMask/metamask-extension#30099
Closed

Add basic tests for the Snap UI rendering system #3060

FrederikBolding opened this issue Feb 4, 2025 · 0 comments · Fixed by MetaMask/metamask-extension#30099
Assignees
@FrederikBolding
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0

Comments

@FrederikBolding
Copy link
Member

No description provided.

@FrederikBolding FrederikBolding self-assigned this Feb 4, 2025
@FrederikBolding FrederikBolding mentioned this issue Feb 4, 2025
Merged
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Feb 7, 2025
@FrederikBolding
test: Add basic tests for SnapUIRenderer (#30099)
358d817 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Establishes a base level of unit testing for the `SnapUIRenderer`
including some snapshot and performance tests.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30099?quickstart=1)

## **Related issues**

Closes MetaMask/snaps#3060
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Feb 7, 2025
@FrederikBolding
test: Add basic tests for SnapUIRenderer (#30099)
67edd4b 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Establishes a base level of unit testing for the `SnapUIRenderer`
including some snapshot and performance tests.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30099?quickstart=1)

## **Related issues**

Closes MetaMask/snaps#3060
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add basic tests for SnapUIRenderer MetaMask/metamask-extension
2 participants
@FrederikBolding @metamaskbot