Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Native Token Streaming Enforcer #48

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Added Native Token Streaming Enforcer #48

merged 3 commits into from
Feb 24, 2025

Conversation

hanzel98
Copy link
Contributor

What?

  • Added NativeTokenStreamingEnforcer, this enforcer allows to transfer native tokens that accrue with time, and an initial amount.

Why?

  • This enforcer allows delegations to be used for streaming services, especially created for native tokens.

How?

  • Allows to accrue tokens based on an amountPerSecond, initialAmount and maximumAmount values set by the delegator when creating the terms.

@hanzel98 hanzel98 requested a review from a team as a code owner February 18, 2025 23:45
@hanzel98 hanzel98 marked this pull request as draft February 19, 2025 15:33
@hanzel98 hanzel98 marked this pull request as ready for review February 20, 2025 21:43
jeffsmale90
jeffsmale90 previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would we consider sharing some of the implementation between the native and erc20 implementations?

A lot of the logic is identical, until the actual validation against the execution data.

@hanzel98 hanzel98 force-pushed the native-token-streaming-enforcer branch from 1d2212b to e17bf2e Compare February 21, 2025 01:01
@hanzel98 hanzel98 merged commit b7fe611 into main Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffsmale90 jeffsmale90 jeffsmale90 approved these changes

@McOso McOso McOso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzel98 @jeffsmale90 @McOso