Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the recipient to the ERC20BalanceGteEnforcer terms #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding the recipient to the ERC20BalanceGteEnforcer terms #38

wants to merge 3 commits into from

Conversation

hanzel98
Copy link
Contributor

@hanzel98 hanzel98 commented Dec 16, 2024 •
edited
Loading

What?

  • Created from the branch release-v1.1.0
  • Adds the recipient to the ERC20BalanceGteEnforcer to make it more similar to the NativeBalanceGteEnforcer

Why?

  • Adding the recipient to the enforcer makes it more flexible. Before the only recipient could be the delegator address.

How?

  • The terms contain the recipient address to check the balance from, the delegator can specify this address when creating the delegation.

@hanzel98 hanzel98 requested a review from a team as a code owner December 16, 2024 17:25
@hanzel98 hanzel98 changed the base branch from main to release-v1.1.0 December 16, 2024 17:27
@hanzel98 hanzel98 self-assigned this Dec 16, 2024
@hanzel98 hanzel98 changed the base branch from release-v1.1.0 to main December 16, 2024 17:34
dylandesrosier
dylandesrosier previously approved these changes Dec 16, 2024
View reviewed changes
@hanzel98 hanzel98 force-pushed the chore/erc20-balance-gte-recipient branch from 2ec3c76 to f8a3178 Compare February 23, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandesrosier dylandesrosier dylandesrosier left review comments

@kevinbluer kevinbluer Awaiting requested review from kevinbluer

@jeffsmale90 jeffsmale90 Awaiting requested review from jeffsmale90

@V00D00-child V00D00-child Awaiting requested review from V00D00-child

@McOso McOso Awaiting requested review from McOso

At least 1 approving review is required to merge this pull request.

Assignees

@hanzel98 hanzel98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzel98 @dylandesrosier