-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure core files are codeowned by Wallet Framework #5274
base: main
Are you sure you want to change the base?
Conversation
I noticed that when new packages are added we may not always know about it. It seems that there are many files that are not codeowned by any team and so anyone is free to update them. This is especially true of the TypeScript config files but also the README. I've added the `github-codeowner` package as a dev dependency to ensure that we can stay on top of this better. You can run this command to find all unowned files: ``` yarn github-codeowner -u ``` And if you're unsure who owns a file, you can also run: ``` yarn github-codeowner who <file> ``` With that context, I've gone through and granted as many files to Wallet Framework as made sense.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/github-codeowners@0.2.1 Shell access is OK, this tool runs the |
/packages/profile-sync-controller @MetaMask/notifications @MetaMask/identity | ||
|
||
## Package Release related | ||
/packages/accounts-controller/package.json @MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to avoid from having to do this 🤔 What I've done isn't right. Maybe there is another way.
Explanation
I noticed that when new packages are added we may not always know about it. It seems that there are many files that are not codeowned by any team and so anyone is free to update them. This is especially true of the TypeScript config files but also the README.
I've added the
github-codeowner
package as a dev dependency to ensure that we can stay on top of this better. You can run this command to find all unowned files:If you're unsure who owns a file, you can also run:
And if you want to see a list of all files and who owns what, you can run:
With that context, I've gone through and granted as many files to Wallet Framework as made sense. With this change there should be far fewer unowned files than before.
References
N/A
Changelog
N/A, developer-only change.
Checklist