feat: Integrate non-evm SIP-26 support into @metamask/multichain
#5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
jiexi
changed the title
@metamask/multichain
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
adonesky1
reviewed
Feb 4, 2025
Comment on lines
+75
to
+78
| } else { | ||
| methods = isCaipChainId(scopeString) | ||
| ? getNonEvmSupportedMethods(scopeString) | ||
| : []; |
There was a problem hiding this comment.
@FrederikBolding just wondering if we've considered what wallet:<caip-2-reference> (e.g. wallet:solana) scoped snaps would mean/look like. Not saying this case won't exist, just curious if we've thought about it.
adonesky1
reviewed
Feb 4, 2025
| optionalScopes: { | ||
| 'foo:1': { | ||
| accounts: ['foo:1:0xdeadbeef'], | ||
| it('gets methods from getNonEvmSupportedMethods for scope non-evm namespace', () => { |
There was a problem hiding this comment.
Suggested change
| it('gets methods from getNonEvmSupportedMethods for scope non-evm namespace', () => { | |
| it('gets methods from getNonEvmSupportedMethods for non-evm (not `eip155`, `wallet` or `wallet:eip155`) scopes', () => { |
adonesky1
reviewed
Feb 4, 2025
Comment on lines
+732
to
+735
| { | ||
| getEvmInternalAccounts: expect.any(Function), | ||
| getNonEvmAccountAddresses: expect.any(Function), | ||
| }, |
There was a problem hiding this comment.
Yeah this pattern is a bit funny, passing these hooks to the utility helpers.... ah well
There was a problem hiding this comment.
yeah... not my favorite
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Updates the
@metamask/multichainpackage to use new hooks provided by the SnapsMultichainRouterto enable non-evm support on the Multichain APIReferences
Ticket: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=94617458&issue=MetaMask%7CMetaMask-planning%7C3989
Extension: MetaMask/metamask-extension#29887
Snaps: MetaMask/snaps#2875
Changelog
@metamask/multichaingetSessionScopes()now expects an additional hooks object as its last param. The hooks object should have agetNonEvmSupportedMethodsproperty whose value should be a function that accepts aCaipChainIdand returns an array of supported methods.caip25CaveatBuilder()now expects two additional properties it's singular param object. The param object should now also have aisNonEvmScopeSupportedproperty whose value should be a function that accepts aCaipChainIdand returns a boolean, and agetNonEvmAccountAddressesproperty whose value should be a function that accepts aCaipChainIdand returns an array of CAIP-10 account addresses.wallet_getSessionhandler now expectsgetNonEvmSupportedMethodsto be provided in it's hooks.sessionScopesresultwallet_invokeMethodhandler now expectsgetNonEvmSupportedMethodsandhandleNonEvmRequestForOriginto be provided in it's hooks.handleNonEvmRequestForOriginshould be a function with the following signature:assertScopeSupported()now expects the following hooks params object as it's last param:assertScopesSupported()now expects the following hooks params object as it's last param:bucketScopes()now expects the following hooks params object as it's last param:bucketScopesBySupport()now expects the following hooks params object as it's last param:getSessionScopes()now expects a hooks object as its last param. The hooks object should have agetNonEvmSupportedMethodsproperty whose value should be a function that accepts aCaipChainIdand returns an array of supported methods.isSupportedScopeString()now expects the a hooks params object as it's last param with the following properties:isSupportedAccount()now expects the a hooks params object as it's last param with the following properties:isSupportedMethod()now expects the a hooks params object as it's last param with the following properties:Checklist