Enforce valid email address for User email #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
requested changes
Oct 28, 2024
server/migrations/community/1a6175c78a10_email_address_format_check.py
Outdated
Show resolved
Hide resolved
varmar05
reviewed
Oct 28, 2024
|
I am not confident with this change and multi language support. |
varmar05
requested changes
Dec 10, 2024
|
@harminius I suggest also to check db against invalid characters and non-utf8 mess, if you can pass me the queries |
harminius
force-pushed
the
enforce_valid_email_address_ce
branch
from
bf00e65 to
04ae6c3
Compare
Pull Request Test Coverage Report for Build 13589212467Details
💛 - Coveralls |
varmar05
requested changes
Mar 3, 2025
varmar05
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2537
Problem:
Users can register with an email containing 'invalid' characters, which causes (our) email service providers' API to crash.
Solution:
Let's extend the existing email validator to disallow some additional characters.