-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding tracking layer while recording #3700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12844973803Details
💛 - Coveralls |
tomasMizera
requested changes
Jan 6, 2025
tomasMizera
requested changes
Jan 15, 2025
tomasMizera
requested changes
Jan 20, 2025
tomasMizera
requested changes
Jan 21, 2025
tomasMizera
approved these changes
Jan 23, 2025
@@ -795,39 +798,57 @@ Item { | |||
} | |||
} | |||
|
|||
MMListDrawer { | |||
id: activeLayerPanel | |||
Loader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for making this dynamic. Just a note for future - we could create a new type of drawer, something like dynamic-drawer
that would have Loader
already incorporated 🤔 💡
Wohooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new filter condition to the recording layer model to ensure a layer is added only if it is not the position tracking layer.
Resolves #3687