Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding tracking layer while recording #3700

Merged
merged 18 commits into from
Jan 23, 2025

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jan 2, 2025

Add a new filter condition to the recording layer model to ensure a layer is added only if it is not the position tracking layer.

|

Resolves #3687

Copy link

github-actions bot commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12844973803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 247 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.6%) to 59.793%

Files with Coverage Reduction New Missed Lines %
input/app/layersmodel.h 1 0.0%
input/app/layersmodel.cpp 8 0.0%
input/app/inpututils.cpp 25 50.5%
input/app/activeproject.cpp 49 69.43%
input/app/layersproxymodel.cpp 80 0.0%
input/app/main.cpp 84 32.35%
Totals Coverage Status
Change from base Build 12688514540: -0.6%
Covered Lines: 7818
Relevant Lines: 13075

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Hiding tracking layer while recording Hiding tracking layer while recording Jan 3, 2025
app/layersproxymodel.cpp Outdated Show resolved Hide resolved
app/qml/main.qml Outdated Show resolved Hide resolved
app/activeproject.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
app/layersproxymodel.cpp Outdated Show resolved Hide resolved
app/layersproxymodel.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Show resolved Hide resolved
app/activeproject.cpp Outdated Show resolved Hide resolved
app/activeproject.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
app/qml/map/MMMapController.qml Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
app/activeproject.cpp Outdated Show resolved Hide resolved
app/qml/map/MMMapController.qml Outdated Show resolved Hide resolved
app/layersproxymodel.cpp Outdated Show resolved Hide resolved
@@ -795,39 +798,57 @@ Item {
}
}

MMListDrawer {
id: activeLayerPanel
Loader {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for making this dynamic. Just a note for future - we could create a new type of drawer, something like dynamic-drawer that would have Loader already incorporated 🤔 💡

@tomasMizera tomasMizera merged commit 3e2f0bc into master Jan 23, 2025
5 of 8 checks passed
@tomasMizera tomasMizera deleted the enhancement/hidingTrackLayerOnRecord branch January 23, 2025 16:31
@tomasMizera
Copy link
Collaborator

Wohooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When recording, tracking layer is presented as an user editable layer
3 participants