Improving UX by hiding editing buttons for readers of a project

app/activeproject.cpp

@@ -185,7 +185,6 @@ bool ActiveProject::forceLoad( const QString &filePath, bool force )
     }
 
     QString role = MerginProjectMetadata::fromCachedJson( CoreUtils::getProjectMetadataPath( mLocalProject.projectDir ) ).role;
-    qDebug() << "ROLE 1 : " << role;
     setProjectRole( role );
 
     updateMapTheme();

app/activeproject.h

@@ -124,19 +124,8 @@ class ActiveProject: public QObject
      * Returns role/permission level of current user for this project
      */
     Q_INVOKABLE QString projectRole() const;
-
     void setProjectRole( const QString &role );
 
-    /**
-     * Calls Mergin API to update current project’s role
-     */
-    void updateUserRoleInActiveProject();
-
-    /**
-     * Update current project’s role
-     */
-    void onProjectRoleUpdated( const QString &projectFullName, const QString &role );
-
   signals:
     void qgsProjectChanged();
     void localProjectChanged( LocalProject project );

core/coreutils.cpp

@@ -21,6 +21,8 @@
 #include <QCryptographicHash>
 #include <QRegularExpression>
 #include <QStorageInfo>
+#include <QJsonDocument>
+#include <QJsonObject>
 
 #include "qcoreapplication.h"
 
@@ -343,3 +345,35 @@ QString CoreUtils::getProjectMetadataPath( QString projectDir )
 
   return projectDir + "/.mergin/mergin.json";
 }
+
+bool CoreUtils::replaceValueInJson( const QString &filePath, const QString &key, const QJsonValue &value )
+{
+  QFile file( filePath );
+  if ( !file.open( QIODevice::ReadOnly ) )
+  {
+    return false;
+  }
+
+  QByteArray data = file.readAll();
+  file.close();
+
+  QJsonDocument doc = QJsonDocument::fromJson( data );
+  if ( !doc.isObject() )
+  {
+    return false;
+  }
+
+  QJsonObject obj = doc.object();
+  obj[key] = value;
+  doc.setObject( obj );
+
+  if ( !file.open( QIODevice::WriteOnly ) )
+  {
+    return false;
+  }
+
+  bool success = ( file.write( doc.toJson() ) != -1 );
+  file.close();
+
+  return success;
+}

core/coreutils.h

@@ -130,6 +130,11 @@ class CoreUtils
      */
     static QString getProjectMetadataPath( QString projectDir );
 
+    /**
+     * Updates a value in a JSON file at the specified top-level key
+     */
+    static bool replaceValueInJson( const QString &filePath, const QString &key, const QJsonValue &value );
+
   private:
     static QString sLogFile;
     static int CHECKSUM_CHUNK_SIZE;

core/merginapi.cpp

@@ -3458,35 +3458,7 @@ bool MerginApi::updateCachedProjectRole( const QString &projectFullName, const Q
   }
 
   QString metadataPath = project.projectDir + "/" + sMetadataFile;
-
-  QFile file( metadataPath );
-  if ( !file.open( QIODevice::ReadOnly ) )
-  {
-    return false;
-  }
-
-  QByteArray data = file.readAll();
-  file.close();
-
-  QJsonDocument doc = QJsonDocument::fromJson( data );
-  if ( !doc.isObject() )
-  {
-    return false;
-  }
-
-  QJsonObject obj = doc.object();
-  obj["role"] = newRole;
-  doc.setObject( obj );
-
-  if ( !file.open( QIODevice::WriteOnly ) )
-  {
-    return false;
-  }
-
-  bool success = ( file.write( doc.toJson() ) != -1 );
-  file.close();
-
-  return success;
+  return CoreUtils::replaceValueInJson( metadataPath, "role", newRole );
 }
 
 void MerginApi::createPathIfNotExists( const QString &filePath )