Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing text wrapping in MMToolbar #3554

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fixing text wrapping in MMToolbar #3554

merged 1 commit into from
Aug 9, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jul 31, 2024

Text font for MMToolbarShortButton can change from t4 to t5 when the button text is too long and needs a better fit, resolvin text wrapping issue and also setting a maximum number of lines to 2, eliding it right after that.

Portrait Before Portrait After
Landscape Before Landscape After

Fixes #3547

@VitorVieiraZ VitorVieiraZ self-assigned this Jul 31, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 31, 2024 22:33
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Aug 1, 2024
@tomasMizera
Copy link
Collaborator

Let's keep it like this for now and I'll double check with Andrej

@tomasMizera tomasMizera removed the FROZEN 🥶 do not merge before upcoming release label Aug 9, 2024
@tomasMizera
Copy link
Collaborator

Let's keep it like this for now :)

@tomasMizera tomasMizera merged commit ce2e752 into master Aug 9, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/toolbarElide branch August 9, 2024 07:22
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word Wrapping Issue in MMToolbar
4 participants