Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Unsaved changes dialog not displayed when using back button #3549

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ValentinBuira
Copy link
Contributor

When editing The Unsaved changes" dialog was not showing up if the cancelled using the header back arrow instead of the system back button. Therefore user could lost their changes

This PR solve the issue and display the dialog when editing or adding a new feature

solve #3525

@ValentinBuira ValentinBuira changed the title Display unsaved dialog when when quit using header back arrow Fix : Unsaved changes dialog not displayed when using back button Jul 29, 2024
Copy link

Pull Request Test Coverage Report for Build 10140382406

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 60.059%

Totals Coverage Status
Change from base Build 10112871979: 0.008%
Covered Lines: 7708
Relevant Lines: 12834

💛 - Coveralls

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomasMizera tomasMizera merged commit efb0012 into master Jul 29, 2024
12 checks passed
@tomasMizera tomasMizera deleted the display-unsaved-change-dialog branch July 29, 2024 09:25
@tomasMizera tomasMizera linked an issue Jul 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsaved changes dialog not displayed when using back button
3 participants